GHSA-4hg4-9mf5-wxxq
incorrect order of evaluation of side effects for some builtins
Packages
Details
As written in the advisory (Markdown source, shown as plain text).
### Impact
The order of evaluation of the arguments of the builtin functions `uint256_addmod`, `uint256_mulmod`, `ecadd` and `ecmul` does not follow source order.
• For `uint256_addmod(a,b,c)` and `uint256_mulmod(a,b,c)`, the order is `c,a,b`.
• For `ecadd(a,b)` and `ecmul(a,b)`, the order is `b,a`.
Note that this behaviour is problematic when the evaluation of one of the arguments produces side effects that other arguments depend on.
### Patches
https://github.com/vyperlang/vyper/pull/3583
### Workarounds
When using builtins from the list above, make sure that the arguments of the expression do not produce side effects or, if one does, that no other argument is dependent on those side effects.
References
External links from the advisory. They lead to third-party sites.
- https://github.com/vyperlang/vyper/security/advisories/GHSA-4hg4-9mf5-wxxq
- https://nvd.nist.gov/vuln/detail/CVE-2023-41052
- https://github.com/vyperlang/vyper/pull/3583
- https://github.com/vyperlang/vyper/commit/78fa8dd8f91ba0cb26277eeffb585c68c83e7daa
- https://github.com/pypa/advisory-database/tree/main/vulns/vyper/PYSEC-2023-168.yaml
- https://github.com/vyperlang/vyper