GHSA-627p-rr78-99rj
GitLab auth uses full name instead of username as user ID, allowing impersonation
Packages
| Ecosystem | Package | Affected | Fixed in |
|---|---|---|---|
| Go | github.com/concourse/concourse | >= 6.4.0, < 6.4.1 | 6.4.1 |
| Go | github.com/concourse/concourse | >= 1.6.1, < 6.3.1 | 6.3.1 |
| Go | github.com/concourse/dex | >= 6.4.0, < 6.4.1 | 6.4.1 |
| Go | github.com/concourse/dex | >= 0.0.0, < 6.3.1 | 6.3.1 |
| Go | github.com/concourse/dex | < 0.0.0-20200730150203-821b48abfd88 | 0.0.0-20200730150203-821b48abfd88 |
| Go | github.com/concourse/concourse | < 0.0.0-20200730151558-b00d1c8d8576 | 0.0.0-20200730151558-b00d1c8d8576 |
| Go | github.com/concourse/concourse | >= 0.0.0, < 1.6.1-0.20200730151558-b00d1c8d8576 | 1.6.1-0.20200730151558-b00d1c8d8576 |
Details
As written in the advisory (Markdown source, shown as plain text).
### Impact
Installations which use the GitLab auth connector are vulnerable to identity spoofing by way of configuring a GitLab account with the same full name as another GitLab user who is granted access to a Concourse team by having their full name listed under `users` in the team configuration or given to the `--gitlab-user` flag.
See the [GitLab auth docs](https://concourse-ci.org/gitlab-auth.html) for details.
Concourse installations which do not configure the GitLab auth connector are not affected.
### Patches
Concourse [v6.3.1](https://github.com/concourse/concourse/releases/tag/v6.3.1) and [v6.4.1](https://github.com/concourse/concourse/releases/tag/v6.4.1) were both released with a fix on August 4th, 2020.
Both versions change the GitLab connector to use the username, rather than the full name. This was always the intent, and the previous behavior was originally reported as a bug (concourse/dex#7) prior to being reported as a security issue.
Any Concourse teams which configure GitLab users will have to switch each user from their full name to their username upon upgrading to these versions.
### Workarounds
GitLab groups do not have this vulnerability, so GitLab users may be moved into groups which are then configured in the Concourse team.
### References
* concourse/dex#12: PR with the fix
### For more information
If you have any questions or comments about this advisory, you may reach us privately at [concourseteam+[email protected]](mailto:concourseteam+[email protected]).
References
External links from the advisory. They lead to third-party sites.