~ / search / GHSA-8jhw-289h-jh2g

GHSA-8jhw-289h-jh2g

Vite's `server.fs.deny` did not deny requests for patterns with directories.

Source: GitHub Advisory Database (reviewed) Moderate CVE-2024-31207

Packages

EcosystemPackageAffectedFixed in
npm vite >= 2.7.0, < 2.9.18 2.9.18
npm vite >= 3.0.0, < 3.2.10 3.2.10
npm vite >= 4.0.0, < 4.5.3 4.5.3
npm vite >= 5.0.0, < 5.0.13 5.0.13
npm vite >= 5.1.0, < 5.1.7 5.1.7
npm vite >= 5.2.0, < 5.2.6 5.2.6

Details

As written in the advisory (Markdown source, shown as plain text).

### Summary [Vite dev server option](https://vitejs.dev/config/server-options.html#server-fs-deny) `server.fs.deny` did not deny requests for patterns with directories. An example of such a pattern is `/foo/**/*`. ### Impact Only apps setting a custom `server.fs.deny` that includes a pattern with directories, and explicitly exposing the Vite dev server to the network (using `--host` or [`server.host` config option](https://vitejs.dev/config/server-options.html#server-host)) are affected. ### Patches Fixed in [email protected], [email protected], [email protected], [email protected], [email protected], [email protected] ### Details `server.fs.deny` uses picomatch with the config of `{ matchBase: true }`. [matchBase](https://github.com/micromatch/picomatch/blob/master/README.md#options:~:text=Description-,basename,-boolean) only matches the basename of the file, not the path due to a bug (https://github.com/micromatch/picomatch/issues/89). The vite config docs read like you should be able to set fs.deny to glob with picomatch. Vite also does not set `{ dot: true }` and that causes [dotfiles not to be denied](https://github.com/micromatch/picomatch/blob/master/README.md#options:~:text=error%20is%20thrown.-,dot,-boolean) unless they are explicitly defined. **Reproduction** Set fs.deny to `['**/.git/**']` and then curl for `/.git/config`. * with `matchBase: true`, you can get any file under `.git/` (config, HEAD, etc). * with `matchBase: false`, you cannot get any file under `.git/` (config, HEAD, etc).

References

External links from the advisory. They lead to third-party sites.