GHSA-93hq-5wgc-jc82

GovernorCompatibilityBravo may trim proposal calldata

Source: GitHub Advisory Database (reviewed) High CVE-2023-30542

Packages

Ecosystem	Package	Affected	Fixed in
npm	@openzeppelin/contracts	>= 4.3.0, < 4.8.3	4.8.3
npm	@openzeppelin/contracts-upgradeable	>= 4.3.0, < 4.8.3	4.8.3

Details

As written in the advisory (Markdown source, shown as plain text).

### Impact The proposal creation entrypoint (`propose`) in `GovernorCompatibilityBravo` allows the creation of proposals with a `signatures` array shorter than the `calldatas` array. This causes the additional elements of the latter to be ignored, and if the proposal succeeds the corresponding actions would eventually execute without any calldata. The `ProposalCreated` event correctly represents what will eventually execute, but the proposal parameters as queried through `getActions` appear to respect the original intended calldata. ### Patches This issue has been patched in v4.8.3. ### Workarounds Ensure that all proposals that pass through governance have equal length `signatures` and `calldatas` parameters.

References

External links from the advisory. They lead to third-party sites.