~ / search / GHSA-c5f8-35qr-q4fm

GHSA-c5f8-35qr-q4fm

HTML injection in email and account expiry notifications

Source: GitHub Advisory Database (reviewed) Moderate CVE-2021-21333

Packages

EcosystemPackageAffectedFixed in
PyPI matrix-synapse < 1.27.0 1.27.0

Details

As written in the advisory (Markdown source, shown as plain text).

### Impact The notification emails sent for notifications for missed messages or for an expiring account are subject to HTML injection. In the case of the notification for missed messages, this could allow an attacker to insert forged content into the email. The account expiry feature is not enabled by default and the HTML injection is not controllable by an attacker. ### Patches This issue is fixed in #9200. ### Workarounds For the missed messages notifications: The `notif.html`, `notif_mail.html`, and `room.html` templates can be overridden with custom templates that manually escapes the variables using [JInja2's `escape` filter](https://jinja.palletsprojects.com/en/2.11.x/templates/#escape). See the `email.template_dir` setting. For the account expiry notifications: 1. Account expiry can be disabled via the `account_validity.enabled` setting. 2. The `notice_expiry.html` template can be overridden with a custom template that manually escapes the variables using [JInja2's `escape` filter](https://jinja.palletsprojects.com/en/2.11.x/templates/#escape). See the `email.template_dir` setting.

References

External links from the advisory. They lead to third-party sites.