GHSA-crh6-fp67-6883
xmldom allows multiple root nodes in a DOM
Packages
| Ecosystem | Package | Affected | Fixed in |
|---|---|---|---|
| npm | xmldom | <= 0.6.0 | no fix listed |
| npm | @xmldom/xmldom | < 0.7.7 | 0.7.7 |
| npm | @xmldom/xmldom | >= 0.8.0, < 0.8.4 | 0.8.4 |
| npm | @xmldom/xmldom | >= 0.9.0-beta.1, < 0.9.0-beta.4 | 0.9.0-beta.4 |
Details
As written in the advisory (Markdown source, shown as plain text).
### Impact
xmldom parses XML that is not well-formed because it contains multiple top level elements, and adds all root nodes to the `childNodes` collection of the `Document`, without reporting any error or throwing.
This breaks the assumption that there is only a single root node in the tree, which led to https://nvd.nist.gov/vuln/detail/CVE-2022-39299 and is a potential issue for dependents.
### Patches
Update to `@xmldom/xmldom@~0.7.7`, `@xmldom/xmldom@~0.8.4` (dist-tag `latest`) or `@xmldom/xmldom@>=0.9.0-beta.4` (dist-tag `next`).
### Workarounds
One of the following approaches might help, depending on your use case:
- Instead of searching for elements in the whole DOM, only search in the `documentElement`.
- Reject a document with a document that has more then 1 `childNode`.
### References
- https://nvd.nist.gov/vuln/detail/CVE-2022-39299
- https://github.com/jindw/xmldom/issues/150
### For more information
If you have any questions or comments about this advisory:
* Email us at [email protected]
References
External links from the advisory. They lead to third-party sites.
- https://github.com/xmldom/xmldom/security/advisories/GHSA-crh6-fp67-6883
- https://nvd.nist.gov/vuln/detail/CVE-2022-39353
- https://github.com/jindw/xmldom/issues/150
- https://github.com/xmldom/xmldom/commit/52a708360c35aa160fcca8621720d71fd0f95f1a
- https://github.com/xmldom/xmldom/commit/7ff7c10ab2961703ac1752e95b4ff60ee4ee6643
- https://github.com/xmldom/xmldom/commit/c02f786216bed70825f9a351c65e61500f51e931
- https://github.com/xmldom/xmldom
- https://github.com/xmldom/xmldom/releases/tag/0.7.7
- https://github.com/xmldom/xmldom/releases/tag/0.8.4
- https://github.com/xmldom/xmldom/releases/tag/0.9.0-beta.4
- https://lists.debian.org/debian-lts-announce/2023/01/msg00000.html