GHSA-xm34-v85h-9pg2
Authentication Bypass by CSRF Weakness
Packages
| Ecosystem | Package | Affected | Fixed in |
|---|---|---|---|
| RubyGems | solidus_auth_devise | >= 1.0.0, < 2.5.4 | 2.5.4 |
Details
As written in the advisory (Markdown source, shown as plain text).
### Impact
CSRF vulnerability that allows user account takeover.
All applications using any version of the frontend component of `solidus_auth_devise` are affected if `protect_from_forgery` method is both:
- Executed whether as:
- A `before_action` callback (the default)
- A `prepend_before_action` (option `prepend: true` given) before the `:load_object` hook in `Spree::UserController` (most likely order to find).
- Configured to use `:null_session` or `:reset_session` strategies (`:null_session` is the default in case the no strategy is given, but `rails --new` generated skeleton use `:exception`).
That means that applications that haven't been configured differently from what it's generated with Rails aren't affected.
### Patches
Users should promptly update to `solidus_auth_devise` version `2.5.4`.
### Workarounds
A couple of options:
- If possible, change your strategy to `:exception`:
```ruby
class ApplicationController < ActionController::Base
protect_from_forgery with: :exception
end
```
- Add the following to `config/application.rb` to at least run the `:exception` strategy on the affected controller:
```ruby
config.after_initialize do
Spree::UsersController.protect_from_forgery with: :exception
end
```
- We've also released new Solidus versions monkey patching `solidus_auth_devise` with the quick fix. Those versions are `v3.1.3`, `v.3.0.3` & `v2.11.12`. See [GHSA-5629-8855-gf4g](https://github.com/solidusio/solidus/security/advisories/GHSA-5629-8855-gf4g) for details.
### References
- [CSRF on the Rails guides](https://guides.rubyonrails.org/security.html#cross-site-request-forgery-csrf)
- [Solidus security](https://solidus.io/security/)
### Thanks
We'd like to thank [vampire000](https://hackerone.com/vampire000) for reporting this issue.
### For more information
If you have any questions or comments about this advisory:
* Open an issue in [solidus_auth_devise](https://github.com/solidusio/solidus_auth_devise/issues) or a discussion in [solidus](https://github.com/solidusio/solidus/discussions)
* Email us at [[email protected]](mailto:[email protected])
* Contact the core team on [Slack](http://slack.solidus.io/)
References
External links from the advisory. They lead to third-party sites.
- https://github.com/solidusio/solidus_auth_devise/security/advisories/GHSA-xm34-v85h-9pg2
- https://nvd.nist.gov/vuln/detail/CVE-2021-41274
- https://github.com/solidusio/solidus_auth_devise/commit/731a6645e90ea9fd228f78ec53c6976c048a0555
- https://github.com/rubysec/ruby-advisory-db/blob/master/gems/solidus_auth_devise/CVE-2021-41274.yml
- https://github.com/solidusio/solidus_auth_devise
- https://github.com/solidusio/solidus_auth_devise/releases/tag/v2.5.4